train icon indicating copy to clipboard operation
train copied to clipboard

handle err when detect amazon linux 2 platform

Open JamesDo-okta opened this issue 2 years ago • 2 comments

Description

Error below is thrown when running on amazon linux 2, which do not have lsb config at either locations listed, we need to fetch from etc/os-release /usr/share/gems/gems/train-core-3.10.7/lib/train/platforms/detect/scanner.rb:39:in `scan': Sorry, we are unable to detect your platform (Train::PlatformDetectionFailed) from /usr/share/gems/gems/train-cor . . .

Related Issue

Types of changes

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [] New content (non-breaking change)
  • [ ] Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • [X] I have read the CONTRIBUTING document.

JamesDo-okta avatar Feb 23 '23 08:02 JamesDo-okta

Hello JamesDo-okta! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes a. If everything looks good, one of them will approve it, and your PR will be merged. b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner. c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

chef-expeditor[bot] avatar Feb 23 '23 08:02 chef-expeditor[bot]

We - the MITRE team - will also be supporting Amazon Linux 2 and Amazon Linux 2023 soon as well.

aaronlippold avatar Jul 26 '23 01:07 aaronlippold