react-router-active-component icon indicating copy to clipboard operation
react-router-active-component copied to clipboard

bump to react-router 3.0.0 and fix issue with passing unknown props

Open killmenot opened this issue 9 years ago • 9 comments

killmenot avatar Nov 02 '16 14:11 killmenot

@insin Found that react-router-active-component doesn't work with react-router 3.0.0. Please take a look at this PR. Maybe you find it useful

killmenot avatar Nov 02 '16 14:11 killmenot

Coverage Status

Coverage increased (+4.2%) to 88.235% when pulling a378f00f0e4909cb81c177af181c401c6cd2b79c on killmenot:react-router-3.0.0 into f0f87c174903c66201490dec8149e88609c83623 on insin:master.

coveralls avatar Nov 02 '16 14:11 coveralls

Current coverage is 88.23% (diff: 90.90%)

Merging #8 into master will increase coverage by 4.23%

@@             master         #8   diff @@
==========================================
  Files             1          1          
  Lines            25         34     +9   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             21         30     +9   
  Misses            4          4          
  Partials          0          0          

Powered by Codecov. Last update f0f87c1...a378f00

codecov-io avatar Nov 02 '16 14:11 codecov-io

Please pull into master so that we can use with the latest react!

4ware avatar Nov 07 '16 13:11 4ware

If you don't want to wait till this gets merged and you use react router v3 in your project: you don't need this plugin to achieve the active state on a parent node - it's simple enough without lib. Just use a component as per: Link

kkarkos avatar Feb 16 '17 01:02 kkarkos

+1

dbkaplun avatar Feb 24 '17 08:02 dbkaplun

+1

jes5e avatar Apr 07 '17 20:04 jes5e

+1

mucahit avatar May 24 '17 08:05 mucahit

+1 can this please be merged

coxjc avatar Aug 25 '17 14:08 coxjc