Bookmarks are not appearing immediately

[0xifarouk]

When adding a bookmark to a streaming video, it's not appearing immediately, I need to play the video for a couple of seconds to get it appears. I am not sure of downloaded videos, but I think they have the same problem.

[allenhumphreys]

Do you mean "favorite"?

[0xifarouk]

No, have a look here.

[allenhumphreys]

Sorry I was confused. Could you upload a brief gif or screen recording of the behavior by chance?

[allenhumphreys]

The delay has to do with generating a thumbnail image we use for the UI. It's likely way more pronounced when using when playing a streaming video compared to a downloaded video (generating a thumbnail will be dependent on internet connection as well). To make the UI snappier, the architecture would need to change somewhat to allow for a deferred delivery of a video thumbnail after the creation of the bookmark.

For reference:

[0xifarouk]

I still don't understand the relation between downloading the thumbnail and creating a bookmark? can't the thumbnail created after the bookmark?

[0xifarouk]

I have uploaded a video here to show you what I exactly mean, it took about 14 seconds for the bookmark icon to appear in the timeline.

[allenhumphreys]

Yeah. This is a valid issue. The program flow seems to optimize for the downloaded videos, but it does work as implemented.

[insidegui]

Yeah we need to implement lazy loading of thumbnails for bookmarks.

_{Sent with GitHawk}