WWDC icon indicating copy to clipboard operation
WWDC copied to clipboard

In selected state, illegible title due to low contrast to background

Open mediter opened this issue 6 years ago • 6 comments

Screen Shot 2019-03-21 at 11 36 54 PM

mediter avatar Mar 22 '19 01:03 mediter

@mediter There is no need to comment that the issue is still occurring. We'll close this issue when it gets fixes.

insidegui avatar Jun 02 '19 06:06 insidegui

@insidegui I followed the trail here for adhering to system theming, apologies for commenting on an old issue with an unrelated topic, but I felt it appropriate to ask before opening a new issue.

Out of pure curiosity, why the persistent dark mode over adhering to the system?

el-greco-de-github avatar May 19 '20 04:05 el-greco-de-github

It’s a media consumption app, it was a design choice.

insidegui avatar May 19 '20 11:05 insidegui

I'll play around with it and see how it looks. Might be able to get it looking nice in both themes. If not, oh well. I have a thing for the light/dark theming (don't lean either way, but am a believer that most apps should adhere to the system...it looks weird when a light app is alongside a bunch of dark ones, or vise versa). EDIT: Ok I do prefer dark mode, but it's a reward for working late, non?

EDIT: Also the WWDC app on iOS now supports both themes, might be cool to match it.

el-greco-de-github avatar May 19 '20 15:05 el-greco-de-github

Thank you for the experimentation, but we don't have any intention of supporting both themes.

insidegui avatar May 19 '20 15:05 insidegui

I couldn't reproduce this anymore as of #600. Anyone?

insidegui avatar May 29 '20 23:05 insidegui