emacs-osx icon indicating copy to clipboard operation
emacs-osx copied to clipboard

Incompatible with flakes

Open antifuchs opened this issue 4 years ago • 3 comments

I attempted to pull this overlay into my flake-based configuration, but unfortunately the fetchTarball in pkgs.nix requires a sha256 argument.

I'm a bit confused why you're pinning a particular version of nixpkgs here in the first place - could this be removed and handled similar to how emacs-overlay does it (where it pushes the nixpkgs that are current at the time the build is pushed to the cache)?

antifuchs avatar Apr 30 '21 16:04 antifuchs

Hey, my initial intention is simply to make the derivation reproducible and is able to be cached by cachix. After all, it is unlikely that every user is using the latest nixpkgs.

I am only 1-2 weeks old in learning Nix and I might be wrong in my understanding. I don't know about flake yet. Let me see what I can do.

Would love to have your help too

inscapist avatar May 01 '21 01:05 inscapist

Hey @sagittaros 👋 I had been maintaining something very similar privately until recently. I just made it public over here: https://github.com/cmacrae/emacs

This was mainly for my personal use, as I was sick of building Emacs with my customizations across my work/personal laptop.
So, I haven't opted to provide several "flavours" as you have here.

As you can see, the repository provides a flake - I'm happy to contribute, if you'd be interested. Or, I'm equally happy to guide you if you'd like to learn a bit about flakes :)

Great start on your Nix journey! 👏

cmacrae avatar May 10 '21 19:05 cmacrae

Awesome! Yes @cmacrae , I would love to have you as a collaborator. I don't use flake personally but I love the direction towards standardization.

Send a PR! I will update the README to cater for it :)

inscapist avatar May 11 '21 06:05 inscapist