mithril icon indicating copy to clipboard operation
mithril copied to clipboard

Remove common test utils from release build

Open Alenar opened this issue 3 years ago • 1 comments

This will prevent us from using common test utilities in production code (since now we don't have to use the fake data anymore). Hopefully this should also reduce the aggregator compilation time.

Alenar avatar Sep 01 '22 08:09 Alenar

Unit Test Results

    7 files  ±0    22 suites  ±0   1m 30s :stopwatch: -41s 293 tests ±0  293 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  294 runs  ±0  294 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit c18fd728. ± Comparison against base commit e0916d3d.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 01 '22 09:09 github-actions[bot]

This doesn't work as expected: cargo will always include the test-util features. The only way to do that correctly would be extracting test-only code in a dedicated crate but ... some of it in common is used by common itself, avoiding circular dependency will be difficult.

Closing :(

Alenar avatar Sep 06 '22 09:09 Alenar