mithril icon indicating copy to clipboard operation
mithril copied to clipboard

Remove `task::block_in_place` in transaction importer

Open Alenar opened this issue 1 year ago • 1 comments

Content

This PR includes a small refactor of aggregator & signer CardanoTransactionImporter threading logic to use task::spawn_blocking instead of task::block_in_place.

Pre-submit checklist

  • Branch
    • [x] Tests are provided (if possible)
    • [ ] Crates versions are updated (if relevant)
    • [x] Commit sequence broadly makes sense
    • [x] Key commits have useful messages
  • PR
    • [x] No clippy warnings in the CI
    • [x] Self-reviewed the diff
    • [ ] Useful pull request description
    • [x] Reviewer requested

Alenar avatar Jul 08 '24 08:07 Alenar

Test Results

    4 files  ±0     52 suites  ±0   8m 52s :stopwatch: -1s 1 148 tests +2  1 148 :white_check_mark: +2  0 :zzz: ±0  0 :x: ±0  1 314 runs  +2  1 314 :white_check_mark: +2  0 :zzz: ±0  0 :x: ±0 

Results for commit 252f549a. ± Comparison against base commit 62883705.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 08 '24 08:07 github-actions[bot]