mithril icon indicating copy to clipboard operation
mithril copied to clipboard

Fix `open_message.is_expired` in aggregator runner

Open dlachaume opened this issue 1 year ago • 1 comments

Content

This PR includes fixes for:

  • get_current_non_certified_open_message: the open_message.is_expired condition was never verified.
  • list_allowed_signed_entity_types_discriminants: if the same valid signed_entity_types was provided several times in the configuration, it was nevertheless added (filter was only on default signed_entity_types).

In addition, we also refactored the UT in the aggregator runner and configuration.

Pre-submit checklist

  • Branch
    • [x] Tests are provided (if possible)
    • [x] Crates versions are updated (if relevant)
    • [ ] CHANGELOG file is updated (if relevant)
    • [x] Commit sequence broadly makes sense
    • [x] Key commits have useful messages
  • PR
    • [x] No clippy warnings in the CI
    • [x] Self-reviewed the diff
    • [x] Useful pull request description
    • [x] Reviewer requested
  • Documentation
    • [ ] Update README file (if relevant)
    • [ ] Update documentation website (if relevant)
    • [ ] Add dev blog post (if relevant)

dlachaume avatar Apr 09 '24 10:04 dlachaume

Test Results

    3 files  ±0     42 suites  ±0   8m 33s :stopwatch: -42s   920 tests +5    920 :white_check_mark: +5  0 :zzz: ±0  0 :x: ±0  1 014 runs  +5  1 014 :white_check_mark: +5  0 :zzz: ±0  0 :x: ±0 

Results for commit 4d0d037a. ± Comparison against base commit fa9e594a.

This pull request removes 6 and adds 11 tests. Note that renamed tests count towards both.
mithril-aggregator ‑ configuration::test::test_list_allowed_signed_entity_types_without_specific_configuration
mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_should_create_new_open_message_for_mithril_stake_distribution_if_none_exists
mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_should_create_open_message_for_cardano_immutables_if_none_exists_and_open_message_mithril_stake_distribution_already_certified
mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_should_return_existing_open_message_for_cardano_immutables_if_already_exists_and_open_message_mithril_stake_distribution_already_certified
mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_should_return_existing_open_message_for_mithril_stake_distribution_if_already_exists_and_not_expired
mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_should_return_existing_open_message_if_all_open_message_already_expired
mithril-aggregator ‑ configuration::test::test_list_allowed_signed_entity_types_discriminant_should_not_duplicate_a_signed_entity_discriminant_type_already_in_default_ones
mithril-aggregator ‑ configuration::test::test_list_allowed_signed_entity_types_discriminant_should_not_return_unknown_signed_entity_types_in_configuration
mithril-aggregator ‑ configuration::test::test_list_allowed_signed_entity_types_discriminant_without_specific_configuration
mithril-aggregator ‑ configuration::test::test_list_allowed_signed_entity_types_discriminants_should_add_signed_entity_types_in_configuration_at_the_end
mithril-aggregator ‑ configuration::test::test_list_allowed_signed_entity_types_discriminants_with_multiple_identical_signed_entity_types_in_configuration_should_not_be_added_several_times
mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_called_for_mithril_stake_distribution_and_then_for_immutable_file
mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_should_create_new_open_message_if_none_exists
mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_should_create_open_message_if_none_exists_and_open_message_already_certified
mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_should_return_existing_open_message_if_already_exists_and_not_expired
mithril-aggregator ‑ runtime::runner::tests::test_get_current_non_certified_open_message_should_return_existing_open_message_if_already_exists_and_open_message_already_certified
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 09 '24 10:04 github-actions[bot]