cloud-provision icon indicating copy to clipboard operation
cloud-provision copied to clipboard

[Suggestion] Remove inlets specific references from the provisioners

Open jsiebens opened this issue 4 years ago • 3 comments

At this moment, many provisioners have some specific, hard-coded references to inlets. Like tags or firewall rules. Referring to this repository: https://github.com/inlets/provision-cloudinit-go, removing those references and making the provisioners more generic, they can be used as a library by others.

Expected Behaviour

Most provisioners create cloud host with hard-coded inlets references, like tags.

Current Behaviour

The provisioners can be used by others without creating inlets tags.

Possible Solution

Pass the inlets references to the provisioners as arguments. I'm aware this can be a tedious task, as there are many provisioners and they all have a target cloud specific implementation.

Steps to Reproduce (for bugs)

N/A

Context

Playing around with the provisioners as a library, I've noticed that the cloud hosts are tagged with "inlets"., while I was creating other, non-inlets relared hosts.

Your Environment

  • inlets version inlets --version N/A
  • Docker/Kubernetes version docker version / kubectl version: N/A
  • Operating System and version (e.g. Linux, Windows, MacOS): N/A
  • Link to your project or a code example to reproduce issue: https://github.com/inlets/provision-cloudinit-go

jsiebens avatar Jan 12 '21 08:01 jsiebens

Does this still need any action?

alexellis avatar Jul 17 '21 17:07 alexellis

Not in this repository, everything is moved to cloud-provision

jsiebens avatar Jul 19 '21 05:07 jsiebens

I've just transferred the issue :+1:

Happy to take recommendations

alexellis avatar Jul 26 '21 13:07 alexellis