avatar-manager icon indicating copy to clipboard operation
avatar-manager copied to clipboard

Plugin does not honor custom CSS classes

Open keyboard2000 opened this issue 8 years ago • 3 comments

avatar_manager_get_avatar function is not using the $args argument from the get_avatar filter. This filter added support for $args on 4.2. Here is a link for reference:

https://developer.wordpress.org/reference/functions/get_avatar/

this is the last line of the WP get_avatar function: return apply_filters( 'get_avatar', $avatar, $id_or_email, $args['size'], $args['default'], $args['alt'], $args );

I recommend adding $args to avatar_manager_get_avatar and to avatar_manager_get_custom_avatar. Also in avatar_manager_get_custom_avatar add support for the $args elements.

keyboard2000 avatar Dec 09 '16 20:12 keyboard2000

yes please add $args. At the moment its not usable for me :( Took me at least 1 hour to find the problem in your code...

emanueljacob avatar Jan 05 '18 22:01 emanueljacob

Hello,

Thank you for getting involved!

You are right, the $args parameter is missing and not yet handled. I'll update as soon as possible the dev branch with a fix. I can't promise a date yet as I'm dealing with some other ongoing projects at the moment. I'm also planning a new release in the near future (to merge the additions intro master and hopefully to fix other issues/feature requests too).

So if you have any other suggestions feel free to comment or open new issues (bugs to fix or features you would like to have). This would help me to plan ahead. Thanks!

Best, Cătălin

cdog avatar Jan 11 '18 09:01 cdog

Please add it… waste half a day trying to get class before discovering it is not supported yet

gregBerthelot avatar Apr 24 '19 13:04 gregBerthelot