kee-frame icon indicating copy to clipboard operation
kee-frame copied to clipboard

:base-path option to allow deployment on non-root paths

Open grmble opened this issue 3 years ago • 3 comments
trafficstars

I would like to be able to deploy kee-frame applications on github project pages which typically look like yourname.github.io/your-project. This does not work at all unless you disable route hashing. But then your application will only work as long as you start it by going to the root route. If you reload the page while on a route not backed by an actual page you get an error.

  • original kee-frame: https://grmble.github.io/learn-you-a-keeframe/part2/
  • with these commit: https://grmble.github.io/learn-you-a-keeframe/part3/

Another option would be to have reitit do all the work. There is a :path option and a :use-fragment option, but I did not actually try this. https://cljdoc.org/d/metosin/reitit/0.5.18/doc/frontend/browser-integration

fixes #109

grmble avatar Oct 28 '22 18:10 grmble

@grmble Thanks a lot for this fix! Since I'm not actively working on kee-frame these days, I'm going to ask you to help me verify this. I'm guessing you are using a git dependency or a fork to use these changes yourself? Would you say the change is working in a stable way, and it's safe to include in the general library? If yes, I'll merge this and see if I can remember the release procedure 😄

ingesolvoll avatar Jan 23 '23 09:01 ingesolvoll

Also, sorry for leaving you hanging on this, @grmble . Hope you found a way to use this without a release.

ingesolvoll avatar Jan 23 '23 09:01 ingesolvoll

@ingesolvoll I am simply using my fork in deps.edn, lack of release is not a problem for me.

I do think the change works in a stable way, but I am only using it in a hobby project with an audience of 1.

grmble avatar Mar 05 '23 10:03 grmble