terraform-aws-ecs-cluster icon indicating copy to clipboard operation
terraform-aws-ecs-cluster copied to clipboard

Use aws_launch_template instead of aws_launch_configuration

Open ragumix opened this issue 3 years ago • 3 comments

Hello!

Due to AWS recommendations to use aws_launch_template instead of aws_launch_configuration looks like it needs to change this module a little bit. https://docs.aws.amazon.com/autoscaling/ec2/userguide/create-launch-config.html

Even in the page of Launch configurations there is a message with recommendation: image

ragumix avatar Oct 21 '22 12:10 ragumix

Hi @ragumix This is on our radar, we're doing some modernisation work on all our tf modules right now (using nullable, using optional, converting from "yes" / "no" to booleans) and when that's done we'll tackle this request 👍

Gryff avatar Oct 28 '22 10:10 Gryff

@Gryff Thanks for all the great work! Chiming in here as my team and stakeholders are getting a bit worried about the ever more persistent AWS mails and health alerts about this deprecation. Do you happen to have an ETA on aws_launch_configuration support? Regards, Jeroen

jeroenhabets avatar Nov 30 '22 13:11 jeroenhabets

@jeroenhabets We don't have an ETA at the moment, but we intend to get to it before the deadline. We would however be very open to a PR, as we have other competing priorities as well.

As a side note, we do offer a paid support contract model in which we provide immediate help with any InfraBlocks related queries. If you want to explore it you can find more information at https://go-atomic.io/products/infrablocks/pricing/ .

jonassvalin avatar Dec 01 '22 12:12 jonassvalin

FYI: I noticed a PR has already been created by @jonassvalin and @Gryff 🥇 : https://github.com/infrablocks/terraform-aws-ecs-cluster/pull/48

jeroenhabets avatar Dec 12 '22 14:12 jeroenhabets

This has now been resolved in version 5.0.0, see https://registry.terraform.io/modules/infrablocks/ecs-cluster/aws/5.0.0 . Please consult the CHANGELOG for details on breaking changes.

jonassvalin avatar Dec 22 '22 12:12 jonassvalin