CometMock icon indicating copy to clipboard operation
CometMock copied to clipboard

Document CometMock/CometBFT differences/deficiencies

Open p-offtermatt opened this issue 2 years ago • 1 comments
trafficstars

There should be documentation for the deficiencies where CometMock does not replicate the behaviour of CometBFT (yet). For example, a folder with Markdown documentation.

p-offtermatt avatar Sep 25 '23 16:09 p-offtermatt

v0.38:

  • The POL Round is hardcoded to 0 when creating a new proposal TODO: link
  • sendInternalMessage is not called when making a proposal
  • The timeout in the context when subscribing to a websocket is fixed manually
  • closeIfSlow is manually set to false
  • We do not submit actual evidence - we just submit bare minimum evidence to tell the application someone misbehaved, but double-checking the actual evidence might not work
  • For RequestPrepareProposal, use maxDataBytes = -1 (unlimited) since we have no mempool anyways

p-offtermatt avatar Oct 04 '23 12:10 p-offtermatt