influxdb-rust icon indicating copy to clipboard operation
influxdb-rust copied to clipboard

Panic on invalid port

Open manio opened this issue 4 years ago • 3 comments

Hi There is a problem with error catching when an invalid port (out of range) is passed to the influxdb client, like this: let client = Client::new("http://localhost:80876", "test");

IMHO it should be catched and passed in Err() instead of panic. Currently it is panicking (from surf crate): thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: InvalidPort', /home/manio/.cargo/registry/src/github.com-1ecc6299db9ec823/surf-2.1.0/src/client.rs:536:42

manio avatar Dec 26 '20 10:12 manio

Good catch! @manio

Empty2k12 avatar Dec 26 '20 18:12 Empty2k12

Hi! If you haven't fixed this, I can take this issue and see what can I do.

samgans avatar Oct 14 '21 19:10 samgans

@samgans Feel free to take a look at this, but I'm not sure if this can be fixed on our end since the stacktrace seems to start within surf.

msrd0 avatar Oct 14 '21 20:10 msrd0