react-native-mlkit icon indicating copy to clipboard operation
react-native-mlkit copied to clipboard

Why does react-native-mlkit-document-scanner requires react-native-mlkit-core

Open filipef101 opened this issue 1 year ago • 1 comments

For all I can tell that dependency is not needed

filipef101 avatar Oct 11 '24 08:10 filipef101

I think it's mostly that it was created using one of the other modules as a template. That said it does import an error type from core -- but I don't see it as particularly important.

Would welcome a PR if you wanted to get rid of it.

trevor-coleman avatar Feb 06 '25 21:02 trevor-coleman

if you're using expo go, never think about it. the modules of this package should be build first, maybe if you're using expo just run npx expo run:android or use build tools like eas.

jejevj avatar Jul 01 '25 10:07 jejevj

I think he meant this dep requirement: https://github.com/infinitered/react-native-mlkit/blob/main/modules/react-native-mlkit-document-scanner/package.json#L29-L31

frankcalise avatar Nov 13 '25 14:11 frankcalise

I verified this dependency can be removed with this repro: https://github.com/frankcalise/ExpoDocScanner

frankcalise avatar Nov 15 '25 12:11 frankcalise