react-native-mlkit
react-native-mlkit copied to clipboard
Why does react-native-mlkit-document-scanner requires react-native-mlkit-core
For all I can tell that dependency is not needed
I think it's mostly that it was created using one of the other modules as a template. That said it does import an error type from core -- but I don't see it as particularly important.
Would welcome a PR if you wanted to get rid of it.
if you're using expo go, never think about it. the modules of this package should be build first, maybe if you're using expo just run npx expo run:android or use build tools like eas.
I think he meant this dep requirement: https://github.com/infinitered/react-native-mlkit/blob/main/modules/react-native-mlkit-document-scanner/package.json#L29-L31
I verified this dependency can be removed with this repro: https://github.com/frankcalise/ExpoDocScanner