ignite icon indicating copy to clipboard operation
ignite copied to clipboard

Remove MobX-State-Tree flag for non-demo projects

Open Jpoliachik opened this issue 1 year ago • 2 comments

This PR adds support for removing MobX-State-Tree code from a non-demo project. Retargeted to v10 branch.

Changes:

  • // @mst inline comments, similar to how demo code removal works
  • Refactored demo.ts removal logic into more generic markup.ts to be shared with @mst comment types too, and make it easy to add additional other types in the future too.
  • Added new replace-next-line markup command type, to help swap out lines of code easily without hot patching in scripts (keeps code replacements inline next to other code)

TODOs:

  • README update

(I'll also add some additional screenshots & videos for testing proof soon)

Jpoliachik avatar Feb 21 '24 17:02 Jpoliachik

@Jpoliachik can you target this against v10 as the base branch?

frankcalise avatar Mar 28 '24 19:03 frankcalise

@frankcalise sure thing, I'll work on this early next week 👍

Jpoliachik avatar Apr 05 '24 20:04 Jpoliachik

This is ready for additional review.

As far as CLI documentation, I added the --mst flag option to the list, and added a blurb under the MST page. I didn't think much else was necessary, since this flag should be straightforward for users, but i'm open to opinions if we think other docs are needed!

Jpoliachik avatar Aug 01 '24 15:08 Jpoliachik

:tada: This PR is included in version 10.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

infinitered-circleci avatar Oct 14 '24 21:10 infinitered-circleci