ignite icon indicating copy to clipboard operation
ignite copied to clipboard

fix(boilerplate): jest.config.js remove jsdom test env

Open frankcalise opened this issue 1 year ago • 2 comments
trafficstars

Please verify the following:

  • [x] yarn test jest tests pass with new tests, if relevant
  • [x] yarn lint eslint checks pass with new code, if relevant
  • [x] yarn format:check prettier checks pass with new code, if relevant
  • [x] README.md (or relevant documentation) has been updated with your changes

Describe your PR

  • Closes #2605
  • Better RNTL support out of box
  • testEnvironment jsdom should only be used for web (which although we support, isn't our main target)

frankcalise avatar Feb 11 '24 04:02 frankcalise

@markrickert that was a result of running yarn test from the root project dir that you hit this error?

frankcalise avatar Feb 13 '24 20:02 frankcalise

@frankcalise Sorry, false alarm... i'm getting a different error actually:

 FAIL  src/tools/demo.test.ts
  ● Test suite failed to run

    TypeError: Cannot read properties of undefined (reading 'testEnvironmentOptions')

      at new NodeEnvironment (node_modules/jest-environment-node/build/index.js:88:49)

Test Suites: 6 failed, 6 total

Though it's probably something i did in my branch.

markrickert avatar Feb 13 '24 20:02 markrickert

:tada: This PR is included in version 9.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

infinitered-circleci avatar Feb 21 '24 17:02 infinitered-circleci