ignite-cookbook icon indicating copy to clipboard operation
ignite-cookbook copied to clipboard

feat(recipes): Custom Vector Icons

Open lodev09 opened this issue 2 years ago • 7 comments
trafficstars

  • Closes #106
  • Implements custom @expo/vector-icons
  • Demonstrates how to use vector-icons into ignite instead of png

Feel free to edit flow, copy, etc.

lodev09 avatar Nov 10 '23 04:11 lodev09

@lodev09 Sorry this sat for so long! I'm going to take a look at it this week.

cdanwards avatar Apr 17 '24 13:04 cdanwards

@cdanwards done.. Thanks so much!

lodev09 avatar Apr 19 '24 15:04 lodev09

Thanks for the contribution!

Curious, could we utilize something like this for the font loading rather than downloading font files? Thoughts?

https://github.com/expo/examples/blob/master/with-router-menus/src/app/_layout.tsx#L14-L17

frankcalise avatar May 08 '24 18:05 frankcalise

@frankcalise for sure. The recipe shows downloading these fonts because it's from FontAwesome 6 which is not provided by expo vector icons (since this is a pro version). When using those free ones, it should work as-is following their instruction

lodev09 avatar May 08 '24 18:05 lodev09

I could add a note in the recipe about skipping the download part if they intend to use those built-in ones.

lodev09 avatar May 08 '24 18:05 lodev09

@lodev09 ohh I see, ok that's great! Do you think it's worth adding a note that if the reader was just looking to enhance the Icon component's registry to @expo/vector-icons that's doable already if they follow that doc page?

This way there is the distinction of why this recipe is different from that

frankcalise avatar May 08 '24 18:05 frankcalise

@frankcalise done

lodev09 avatar May 08 '24 19:05 lodev09

@lodev09 sorry but one last thing before we merge. Since this is our first community contribution we had some discussion internally and wanted to verify that you would agree to merging this with a Creative Commons license. (We're adding it to the PR process going forward). Once that happens we'll merge! Thanks again for the contribution!

cdanwards avatar Jun 14 '24 14:06 cdanwards

@cdanwards yes sir, agreed 👍

lodev09 avatar Jun 14 '24 16:06 lodev09

@lodev09 🙌🏼

cdanwards avatar Jun 14 '24 17:06 cdanwards