Error in view data / url prop

[kimhf]

trafficstars

Currently if the project has the base url localhost/test and we navigate to some/sub/page the result is a url change to localhost/test/test/some/sub/page in the brower by inertiajs. This url no longer matches the route we are currently at.

The issue seems to be that a path as part of the base url is not handled correctly.

This line in \Inertia\Response causes the issue.

'url' => $request->getBaseUrl().$request->getRequestUri(),

[kimhf]

I have created a pull request #360 with a possible solution to this issue.

[rhysemmerson]

This looks like a duplicate of #236

[kimhf]

I do not believe this is a duplicate of #236, but a solution might solve both issues.

[NickSdot]

@claudiodekker seems this was introduced in https://github.com/inertiajs/inertia-laravel/pull/333

If I am not mistaken this anyway shouldn't be Inertia's job. The behavior before was just fine and the issue which lead to the PR should be solvable by e.g. setting root in the NGINX config (untested).

[kimhf]

It should in my opinion be Inertia's job to handle different server configurations. The problem as far as I can see is that #333 is the wrong fix for the problem. At least in my case where I'm setting RewriteBase /to/project in .htaccess

The combination of $request->getBaseUrl() + $request->getRequestUri() generates a invalid url with that server config. Looking at how fullUrl() / getUri() builds the url $request->getBaseUrl() + $request->getPathInfo() + $queryString (or fullUrl()) seems to be the right approach and should handle more server configurations.

It seems to me that $request->getBaseUrl() + $request->getRequestUri() are not intended to be combined together in that way.

[lotsofbytes]

Thanks @kimhf. I can't wait this gets released.

I have just started using inertia a couple days ago. This will solve my problem with a project in subfolder.

[w99910]

I hope this commit will be merged soon because it is seemed to be that this will solve my problem too.

[juancarlos-ctg]

Hope this gets fixed soon, it fixed my issue as well. ✊

[qbuache]

also interested in a fix, at the moment I have to mess with the toResponse function in /vendor/inertiajs/inertia-laravel/src/Response.php

[romanmartushev]

I am also interested in this fix! Currently unable to update a site to Laravel 9 because of this issue.

[dopesky]

This also fixed my issue. Hope it gets merged soon.

[lucraraujo]

Holy sh**! I lost one week of my life because of this bug! I tested 3 different web server (apache, nginx, IIS) to finally find this bug!

[andrew1601]

I noticed this issue after submitting issue #421 and proposing PR #422

I spent 4 hours this afternoon before finding this bug!

also interested in a fix, at the moment I have to mess with the toResponse function in /vendor/inertiajs/inertia-laravel/src/Response.php

This is how I've dealt with it too in the meantime.

[Pachekoko]

This fixed my problem too, I'm glad I found the solution I was struggling since the beggining of this week. Thanks

[CristianSitov]

I spent a lot of time trying to fix this thing in my nginx conf, until I started looking at Laravel & InertiaJs packages to understand the source of the duplication. Definitely this patch is the right solution for the problem. I can't wait to see this merged (in the mean time, I'm going to production with a fork ¯_(ツ)_/¯).

[sinceow]

I can't wait to see this merged!!!!!!!!

[kentchang84]

Awaiting the merge, almost a year, gosh

[raghed-kahil]

I have same issue so i downloaded the package and edited it localy.

Actually i also edited svelte package too.