indico
indico copied to clipboard
indico
Improve Booking Linking
Closes #6811 Closes #6568
Description
This PR:
- [x] Shows bookings to link with, starting from the event's date instead of the current date.
- [x] Allows the user to link with any existing booking. Currently only those that overlap were shown.
- [x] Adds a filter to display bookings that do not overlap with the event's dates.
Screenshots
Works much better now, thanks! What do you think about somehow (red? some icon?) highlighting the "Booked for ..." if the booking cannot be linked because it's for someone else.
What do you think about somehow (red? some icon?) highlighting the "Booked for ..." if the booking cannot be linked because it's for someone else.
If I'd have to say one thing I'm not good at, it'd be UI. A red-ish color is fine for me, but simply because it does the job and it's the easiest to implement. But here's your call, I'd say.
Something that we missed on the original PR: it might be nice to have the event name that you are linking to, in the confirmation prompt (e.g. "Are you sure you want to link this event (<event_name>) to this booking?").
Hrm, not sure. You get to linking mode from your event's management area, so it should be very clear what you're linking. It's also shown in the linking mode bar.
The prompt is mainly so you don't accidentally click thinking there's another dialog or whatever before the link is actually created.
(in any case it'd probably trivial to do since the information is in the state)
Works much better now, thanks! What do you think about somehow (red? some icon?) highlighting the "Booked for ..." if the booking cannot be linked because it's for someone else.
How about using stripped diagonal lines as background (like in the screenshot below) for those cases? Red seems too aggressive for something that is not an error or anything of the sort.
