wesleymatosdev

Results 118 comments of wesleymatosdev

Hey @tobihans, if you need help with it, let me know. I added myself to the queue as I have looked at it in the past, and now I have...

PR ianstormtaylor/slate#5523 created, can you review it @zbeyens? @algora-pbc folks, can you link my attempt to the PR on slate? thanks!

Hey folks, as mentioned on [MDN's setAttribute documentation](https://developer.mozilla.org/en-US/docs/Web/API/Element/setAttribute#gecko_notes) > Using setAttribute() to modify certain attributes, most notably value in XUL, works inconsistently, as the attribute specifies the default value. To...

@tobySolutions @aidenybai, is there any component we should use instead of a slot, or should we render just the plain component received?

> [There](https://github.com/rust-lang/rustfmt/blob/041f11315923b0e4b0328b3bb6366de9148c7b6b/src/config/mod.rs#L217) should be semver match instead of just eq, I suppose. Hey guys, willing to help. Should I open a PR to it?

#6063 opened @ytmimi. Can you check if it makes sense?

And regarding the conditions: - [ ] Is the default value correct ? - [ ] The design and implementation of the option are sound and clean. - [ ]...

changes addressed @ytmimi. Thanks for the quick feedback :smile:

My preferred path would be, if `1.34` is on the `required_version`, should return true to any version above `1.35`, as this is the default behavior for [`rust-version`](https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field), as described on...