vuepress icon indicating copy to clipboard operation
vuepress copied to clipboard

fix: localize 404 page fix #1987

Open yamashita-ki opened this issue 3 years ago • 2 comments

Summary

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari
  • [x] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

yamashita-ki avatar Dec 11 '21 06:12 yamashita-ki

Hey @meteorlxy Would you mind checking this one?

yamashita-ki avatar Dec 11 '21 07:12 yamashita-ki

@ulivz I would like to ask you two things.

I just checked the preview link, but found an obvious flash (from en to zn)

So, 404 page supports i18n without my commit?

obvious flash

flash means session flash?

yamashita-ki avatar Aug 07 '22 11:08 yamashita-ki