apollo-tracing-ruby icon indicating copy to clipboard operation
apollo-tracing-ruby copied to clipboard

Published 20 hours ago • verified publisher icon uniiverse

Measure duration using Process.clock_gettime() rather than Time.now.utc

Open jturkel opened this issue 7 years ago • 3 comments

This PR optimizes duration calculations to use Process.clock_gettime(Process::CLOCK_MONOTONIC, :nanosecond) rather than Time.now.utc. Similar optimizations landed in Benchmark in this change with a follow up simplification in this commit. On my MacBook Pro running High Sierra with a 2.2 GHz Intel Core i7 processor this speeds up a GraphQL query that returns roughly 1,089 field values from 529ms to 201ms.

jturkel avatar Aug 08 '18 00:08 jturkel

The Travis build is failing because https://registry.npmjs.org/apollo-engine-binary-darwin/-/apollo-engine-binary-linux-0.2018.4-20-g7a8822c14.tgz can't be downloaded. I assume this is unrelated to my changes.

jturkel avatar Aug 08 '18 01:08 jturkel

Issues go stale after a week of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 2 weeks of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification. /lifecycle stale

telescopebot avatar Aug 11 '22 11:08 telescopebot

Stale issues rot after 2 weeks of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 2 weeks of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification. /lifecycle rotten

telescopebot avatar Aug 25 '22 11:08 telescopebot

Rotten issues close after 2 weeks of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification. /close

telescopebot avatar Sep 08 '22 11:09 telescopebot

@telescopebot: Closed this PR.

In response to this:

Rotten issues close after 2 weeks of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

telescope-tekton[bot] avatar Sep 08 '22 11:09 telescope-tekton[bot]