javascript-algorithms

javascript-algorithms copied to clipboard

As I am using dark mode in GitHub, I came across at least a couple of diagrams that were not compatible with dark mode, making it difficult to understand the diagram or even see that the diagram is there in the first place.

Some examples are:

Doubly Linked List

Hash Table

I believe the problem is due to the images (or SVG file) here being transparent and it would most likely be fixed by adding a white background to the image. I have not checked all the files but there could be more of such images/diagrams.

Though it's a small issue, I just thought I could bring it up as I haven't seen anyone else report this issue.

Hey there, I am interested in helping out with this issue. Where should i start?

Starting from Nov 21, Github offers several ways to add dark mode alternatives for images:

https://github.blog/changelog/2021-11-24-specify-theme-context-for-images-in-markdown/ https://github.blog/changelog/2022-05-19-specify-theme-context-for-images-in-markdown-beta/

I use the second for the logos, but I don't know if it still considered a beta after over a year.

The biggest problem is to choose a color that will fit for all the dark modes and one that will fit all the light modes.

The biggest issue is the the repo seems to not be updated or maintained anymore (?), by looking at the amount of PR and issues.