javascript-algorithms icon indicating copy to clipboard operation
javascript-algorithms copied to clipboard

Published 20 hours ago • verified publisher icon trekhleb

Adding of a method that get the successor of a node inside the birany search tree

Open dilane3 opened this issue 4 years ago • 6 comments

I have added one file to your repository, this file contains a function which take a number and returns the power of two which is directly greater than the given number. I have also added a test file and a README file.

dilane3 avatar Dec 12 '20 17:12 dilane3

Codecov Report

Merging #589 (4917139) into master (1b0e27a) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #589   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          153       154    +1     
  Lines         2645      2649    +4     
  Branches       438       439    +1     
=========================================
+ Hits          2645      2649    +4
Impacted Files Coverage Δ
...greater-than-number/powerOfTwoGreaterThanNumber.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b0e27a...4917139. Read the comment docs.

codecov[bot] avatar Dec 12 '20 17:12 codecov[bot]

How can I complete my checks ?, I remark that I need to do the continuous integration but how can I do it ? Thanks

dilane3 avatar Dec 13 '20 08:12 dilane3

To be honest, this looks more like basic logarithm operations for a math class and less like a CS algorithm for this repo. Maybe if the code found the first 1 in the binary representation and cleared bits on the right?

lazarljubenovic avatar Dec 13 '20 11:12 lazarljubenovic

For you I should not use the logarithm operation ? because this looks more like the math class ?

dilane3 avatar Dec 13 '20 13:12 dilane3

I'm not commenting on the code itself, I'm commenting on its inclusion in the project which has the usual bunch of CS algorithms. Calculating the "next power of two" is just applying the well-known logarithm function. In my opinion, it doesn't fit here. But I'm not the maintainer, just giving my two cents.

lazarljubenovic avatar Dec 13 '20 16:12 lazarljubenovic

Ok. I understand that you say. But I wanted to do it because I have another contribution for this repository and which use it, then I have seen better to separate it.

This is my first pull request. I am a beginner, I would like to learn about git GitHub and JavaScript.

dilane3 avatar Dec 13 '20 16:12 dilane3