javascript-algorithms icon indicating copy to clipboard operation
javascript-algorithms copied to clipboard

Published 20 hours ago • verified publisher icon trekhleb

Could we have just one way of doing the swapping to have better consistency across the code

Open cjkumaresh opened this issue 6 years ago • 3 comments

Like how we have here https://github.com/trekhleb/javascript-algorithms/blob/master/src/algorithms/sorting/bubble-sort/BubbleSort.js#L22 instead of https://github.com/trekhleb/javascript-algorithms/blob/master/src/algorithms/sorting/shell-sort/ShellSort.js#L24

cjkumaresh avatar Feb 19 '19 05:02 cjkumaresh

The former makes use of ES6 destructuring whilst the latter does not. I think the question is whether ES6 is recommended in this project

ktrongnhan avatar Apr 15 '19 14:04 ktrongnhan

I feel that this project is trying to use modern language standards. I support the use of ES6 destructuring.

mik-laj avatar Jun 22 '19 08:06 mik-laj

Hi, we are four students working on this issue as part of a course in software development.

ekner avatar Mar 07 '22 10:03 ekner