tsai icon indicating copy to clipboard operation
tsai copied to clipboard

TST parameter fixup

Open andersgb opened this issue 1 year ago • 1 comments

First commit should be trivially correct (docstring only) Second commit fixes a bug, which was my original intention for opening this PR Third commit reintroduces the original behavior because I don't think the assertion is necessary. I tried to understand and compare to how the pytorch implementation of multi head attention handles these dimensions.

So the net change of this PR is only docstring changes. See commit messages for further details.

andersgb avatar Apr 23 '24 12:04 andersgb

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB