react-native-safe-area-context icon indicating copy to clipboard operation
react-native-safe-area-context copied to clipboard

install_modules_dependencies(s) outside of use_fabric

Open billnbell opened this issue 2 years ago • 2 comments

https://github.com/th3rdwave/react-native-safe-area-context/blob/930f703ca3337f407e2df13d1f4ec8e9ffcdb654/react-native-safe-area-context.podspec#L24

This line for install_module_dependencies(s) is in wrong spot.

See: https://reactnative.dev/docs/the-new-architecture/backward-compatibility-fabric-components

Please take use_fabric off, and remove dependencies.

billnbell avatar Jul 12 '23 04:07 billnbell

Test it with:

cd ios && NO_FLIPPER=1 USE_FRAMEWORKS=static RCT_NEW_ARCH_ENABLED=1 pod install --repo-update && cd .. && yarn ios

billnbell avatar Jul 12 '23 04:07 billnbell

install_module_dependencies is not available in older rn versions so I prefer not to use it outside of fabric for now.

janicduplessis avatar Jul 12 '23 05:07 janicduplessis