tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

performance: improve performance of `RequestTemplate`

Open tusharmath opened this issue 1 year ago • 8 comments

The set_body method can be optimized for the case of ApplicationXWwwFormUrlencoded. Currently, it renders the mustache template as a string, then converts it to serde_json and then again converts it to a form_url_encoded value.

Ideally, there it shouldn't take such redundant steps to make this transformation.

Technical Requirements

  • Write idiomatic rust code while making an optimization
  • Write criterion benchmarks to compare the before and after performance.

tusharmath avatar Jan 13 '24 13:01 tusharmath

/bounty 200$

tusharmath avatar Jan 13 '24 13:01 tusharmath

~~## 💎 $200 bounty • Tailcall Inc.~~

~~### Steps to solve:~~ ~~1. Start working: Comment /attempt #934 with your implementation plan~~ ~~2. Submit work: Create a pull request including /claim #934 in the PR body to claim the bounty~~ ~~3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts~~

~~### Additional opportunities:~~ ~~* 🔴 Livestream on Algora TV while solving this bounty & earn $200 upon merge! Make sure to have your camera and microphone on. Comment /livestream once live~~

~~🙏 Thank you for contributing to tailcallhq/tailcall!~~ ~~🧐 Checkout our guidelines before you get started.~~

Attempt Started (GMT+0) Solution
🟢 @shivamklr Mar 12, 2024, 10:49:44 AM WIP

algora-pbc[bot] avatar Jan 13 '24 13:01 algora-pbc[bot]

Hi! @tusharmath I want to work on the issue, can you assign it to me.

SOUMOJIT-CHAKRABORTY avatar Jan 13 '24 15:01 SOUMOJIT-CHAKRABORTY

@tusharmath Can I be assigned to this?

guhitb avatar Jan 30 '24 18:01 guhitb

Sure go ahead

tusharmath avatar Jan 30 '24 18:01 tusharmath

/attempt #934

shivamklr avatar Mar 12 '24 10:03 shivamklr

@shivamklr: Another person is already attempting this issue. Please don't start working on this issue unless you were explicitly asked to do so.

algora-pbc[bot] avatar Mar 12 '24 10:03 algora-pbc[bot]

Hey @guhitb, can I take up from where you stopped on #1084?

wesleymatosdev avatar Apr 23 '24 22:04 wesleymatosdev

Action required: Issue inactive for 30 days. Status update or closure in 7 days.

github-actions[bot] avatar Jun 05 '24 21:06 github-actions[bot]

Issue closed after 7 days of inactivity.

github-actions[bot] avatar Jun 12 '24 22:06 github-actions[bot]