tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

Published 20 hours ago • verified publisher icon tailcallhq

fix: Simplify init subcommand

Open neo773 opened this issue 1 year ago • 6 comments

Fixes #698

  • [x] I ran cargo test successfully.
  • [x] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

/claim #698

neo773 avatar Dec 10 '23 13:12 neo773

tested the changes locally, it works as expected

pushed your suggestion

neo773 avatar Dec 12 '23 12:12 neo773

Hey, @neo773, PR is approved, but I noticed a few minutes ago that resource is an external library, so we can likely delete it as the only place it was used is on the init command.

wesleymatosdev avatar Dec 12 '23 13:12 wesleymatosdev

@ologbonowiwi Resolved, thanks.

neo773 avatar Dec 12 '23 13:12 neo773

Action required: PR inactive for 2 days. Status update or closure in 5 days.

github-actions[bot] avatar Dec 17 '23 12:12 github-actions[bot]

@tusharmath @meskill is there anything missing to merge this one guys?

wesleymatosdev avatar Dec 20 '23 16:12 wesleymatosdev

@tusharmath @meskill is there anything missing to merge this one guys?

There were some uncertainties about the implementation. @neo773 could you please take a look into the last comments for the issue and say what do you think about suggested implementation?

meskill avatar Dec 20 '23 21:12 meskill