llmflows icon indicating copy to clipboard operation
llmflows copied to clipboard

refactor: type hints not very informative

Open inspiralpatterns opened this issue 2 years ago • 0 comments

https://github.com/stoyan-stoyanov/llmflows/blob/6ce79a8cc3b06e799d2b6eb6f6e8e78354f68dcd/llmflows/flows/chat_flowstep.py#L96

I find using Any everywhere generally frowned upon: you want to use type hints to leverage the power of a static type checker such as e.g. mypy and for better documentation. Having a Tuple that can give you elements of any type does not provide much information and does not help much in telling the type checker what you really expect as output.

inspiralpatterns avatar Jul 13 '23 21:07 inspiralpatterns