SonataAdminBundle icon indicating copy to clipboard operation
SonataAdminBundle copied to clipboard

Upgrade to AdminLTE 3

Open core23 opened this issue 2 years ago • 3 comments

Subject

This is a new approach to solve #7156. It is basically based on #7740.

I am targeting this branch, because the style update is a breaking change. Some css classes changed when upgrading from bootstrap 3 > 4 (e.g. box became card).

Closes #7156

Changelog

### Changed
- Add support for AdminLTE v3
- Add support for jQuery v3

To do

  • [ ] Do the upgrade
    • [X] Update dependencies
    • [ ] Update all template
    • [ ] Update all PHP components
    • [ ] Update custom JavaScript
    • [ ] Update custom CSS
  • [ ] Test it on a real project
  • [ ] Update documentation
    • [ ] Update the documentation and screenshots
    • [ ] Update CHANGELOG
  • [ ] 3rd Party
    • [ ] Update SonataUserBundle login template
    • [ ] Update SonataMediaBundle admin template overrides

Functions to check

  • [x] General layout (sidebar, top navigation, ...)
  • [ ] Filter list
  • [ ] Quick edit in list
  • [ ] Modal item selection
  • [ ] Show item page
  • [ ] Edit item page

Nice to have

  • [ ] Move inline JavaScript to admin.js
  • [ ] Remove deprecated bootlint

core23 avatar Sep 18 '23 13:09 core23

I think your description is wrong, should be from bootstrap 3 > 4?

from bootstrap 3 > 5

AdminLTE 3 is using Bootstrap 4 AdminLTE 4 (WIP, not released yet) is using Bootstrap 5

Seb33300 avatar Sep 20 '23 08:09 Seb33300

You're right. There's plenty to do to use bootstrap 5: https://github.com/ColorlibHQ/AdminLTE/milestone/7

core23 avatar Sep 20 '23 08:09 core23

Paused until https://github.com/sonata-project/SonataAdminBundle/issues/8117 is solved

core23 avatar Oct 08 '23 11:10 core23

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 05 '24 12:04 github-actions[bot]