react-multi-date-picker icon indicating copy to clipboard operation
react-multi-date-picker copied to clipboard

Missing TS definition for DatePickerRef isOpen property

Open danieliser opened this issue 2 years ago • 4 comments

Currently the TS definition for DatePickerRef doesn't include the isOpen property.

danieliser avatar Oct 31 '23 07:10 danieliser

I had added this prop during development but didn't end up using it anywhere. I didn't think it would be useful, so I didn't add it to the declaration type. However, I went ahead and added it anyway. Thanks for catching this.

shahabyazdi avatar Nov 04 '23 05:11 shahabyazdi

No worries, we used it in custom close methods. Had a custom Plugin in our datepicker that was triggering a close on click, had to custom make the close on click outside functionality to account for this.

danieliser avatar Nov 06 '23 02:11 danieliser

Could you make 4.4.2, which has this change included, be downloadable via NPM as well, please? This is a useful property to have to programatically open/close the picker.

pontushed avatar Jan 15 '24 16:01 pontushed

Sorry for the late answer! I forgot to publish v4.2.2. It's now available in v4.5.0.

shahabyazdi avatar May 18 '24 13:05 shahabyazdi