rustfmt

rustfmt copied to clipboard

Tracking issue for required_version

Would it make sense for required_version to support SemVer semantics similar to Cargo dependencies? This would make it easier to use in cases where CI agents are updated automatically.

For instance, if somebody sets required_version = "1.4.36" but their CI agent is updated separately with a newer patch-release such as 1.4.37, currently their CI build would fail.

Why is this not stabilized yet?

Why is this not stabilized yet?

https://github.com/rust-lang/rustfmt/discussions/5365 https://github.com/rust-lang/rustfmt/discussions/5367

There should be semver match instead of just eq, I suppose.

There should be semver match instead of just eq, I suppose.

I think so too.

There should be semver match instead of just eq, I suppose.

Hey guys, willing to help. Should I open a PR to it?

@ologbonowiwi thanks for offering to help. Before submitting a PR could you open an issue describing what you're planning to implement. I think it might be useful to discuss the approach before jumping in and working on this.

#6063 opened @ytmimi. Can you check if it makes sense?

And regarding the conditions:

• [ ] Is the default value correct ?
• [ ] The design and implementation of the option are sound and clean.
• [ ] The option is well tested, both in unit tests and, optimally, in real usage.
• [x] There is no open bug about the option that prevents its use. (I've checked this one, no bugs open)

Which of them still needs to be worked on?