LLMs-from-scratch icon indicating copy to clipboard operation
LLMs-from-scratch copied to clipboard

Fix: Typo in `appendix_d.py` comments.

Open PrinceSajjadHussain opened this issue 4 months ago • 1 comments

In appendix_d.py the phrase "which lead to" should be "which leads to".

Applied fixes: --- a/pkg/llms_from_scratch/appendix_d.py +++ b/pkg/llms_from_scratch/appendix_d.py @@ -76,7 +76,7 @@ if global_step > warmup_steps: torch.nn.utils.clip_grad_norm_(model.parameters(), max_norm=1.0) else:

  •            if global_step >= warmup_steps:  # the book originally used global_step > warmup_steps, which lead to a skipped clipping step after warmup
    
  •            if global_step >= warmup_steps:  # the book originally used global_step > warmup_steps, which leads to a skipped clipping step after warmup
                   torch.nn.utils.clip_grad_norm_(model.parameters(), max_norm=1.0)
    
           optimizer.step()
    

PrinceSajjadHussain avatar Jun 20 '25 17:06 PrinceSajjadHussain