newman-dashboard icon indicating copy to clipboard operation
newman-dashboard copied to clipboard

Move constants to provider files

Open VallariAg opened this issue 3 years ago • 3 comments

Solves #34

Moved all the constants to provider files.

VallariAg avatar Nov 15 '21 22:11 VallariAg

@VallariAg Thank you for your contribution! 🎉

But this is not what we were looking for. We just wanted to move the constants file before to a new destination. We need the constants to be at a single place for reusability so other files can use it from there and on change, we won't have to make that change everywhere.

elit-altum avatar Nov 21 '21 10:11 elit-altum

@elit-altum

We just wanted to move the constants file before to a new destination.

I see, so do we just want to move the files from dashboard/lib/constants/ to dashboard/server/constants/?

Also, I'm interested to make more meaningful contributions to this project. Can you help me pick a ticket that I could work on?

VallariAg avatar Dec 15 '21 17:12 VallariAg

@VallariAg @elit-altum Actually it would make sense for the files that are the "provider" of the constants to define and export them. The consumers (who call the APIs with the constant values) should import and use them.

coditva avatar Dec 21 '21 09:12 coditva