pi-top-Python-SDK icon indicating copy to clipboard operation
pi-top-Python-SDK copied to clipboard

Add device orientation control to rover controller

Open angusjfw opened this issue 3 years ago • 8 comments

Status Ticket/Issue
Ready/Hold Ticket

Main changes

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

Manual testing tips

Tag anyone who definitely needs to review or help

angusjfw avatar Jun 22 '22 10:06 angusjfw

Codecov Report

Merging #543 (8712dc7) into master (6bdf48c) will decrease coverage by 0.36%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
- Coverage   57.29%   56.93%   -0.37%     
==========================================
  Files         146      146              
  Lines        6920     6929       +9     
==========================================
- Hits         3965     3945      -20     
- Misses       2955     2984      +29     
Flag Coverage Δ
unittests 56.93% <0.00%> (-0.37%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pitop/labs/web/blueprints/messaging/__init__.py 0.00% <0.00%> (ø)
pitop/labs/web/blueprints/rover/__init__.py 0.00% <0.00%> (ø)
pitop/labs/web/webcontroller.py 0.00% <ø> (ø)
pitop/labs/web/webserver.py 0.00% <0.00%> (ø)
pitop/processing/core/load_models.py 44.89% <0.00%> (-40.82%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jun 22 '22 10:06 codecov[bot]

This pull request introduces 1 alert when merging 6bf4540673e9fc8957918e04756c284ecc448403 into 460879b861d68dd2a105ca4cd6165442b2179388 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

lgtm-com[bot] avatar Jun 23 '22 16:06 lgtm-com[bot]

This pull request introduces 1 alert when merging 8f32f843a291adc6ff3df6381dcfb144e34fafd7 into 460879b861d68dd2a105ca4cd6165442b2179388 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

lgtm-com[bot] avatar Jun 24 '22 15:06 lgtm-com[bot]

This pull request introduces 1 alert when merging feef61ee35b53b5be6d7a2b22e0107b605c7d2a1 into 54d25421649f89587aff565c0cc13fa5d13c2312 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

lgtm-com[bot] avatar Jun 24 '22 16:06 lgtm-com[bot]

This pull request introduces 1 alert when merging ed89664281a5aa07057f953501ea07ff1652bdcb into 54d25421649f89587aff565c0cc13fa5d13c2312 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

lgtm-com[bot] avatar Jun 24 '22 16:06 lgtm-com[bot]

This pull request introduces 1 alert when merging e215ec1f6b49039766772ab24e5deec72cb2420f into 54d25421649f89587aff565c0cc13fa5d13c2312 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

lgtm-com[bot] avatar Jun 24 '22 17:06 lgtm-com[bot]

This pull request introduces 1 alert when merging 2814478c1c1d8139d97a2dea7a96375bed656764 into 54d25421649f89587aff565c0cc13fa5d13c2312 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

lgtm-com[bot] avatar Jun 24 '22 20:06 lgtm-com[bot]

This pull request introduces 1 alert when merging 8712dc7b1aea006acb4d1a26a845e4eccb9704ee into 6bdf48c903bc88a78f804fe516eb1544db64d5bd - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

lgtm-com[bot] avatar Aug 15 '22 11:08 lgtm-com[bot]