pi-top-Python-SDK icon indicating copy to clipboard operation
pi-top-Python-SDK copied to clipboard

Published 20 hours ago • verified publisher icon pi-top

[WIP] 4wd controller

Open m-roberts opened this issue 4 years ago • 2 comments

m-roberts avatar Aug 10 '21 11:08 m-roberts

Codecov Report

Merging #426 (78783c3) into master (854e835) will decrease coverage by 11.60%. The diff coverage is 35.00%.

:exclamation: Current head 78783c3 differs from pull request most recent head 98887a6. Consider uploading reports for the commit 98887a6 to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           master     #426       +/-   ##
===========================================
- Coverage   58.56%   46.95%   -11.61%     
===========================================
  Files          72       71        -1     
  Lines        2756     2760        +4     
===========================================
- Hits         1614     1296      -318     
- Misses       1142     1464      +322
Flag Coverage Δ
unittests 46.95% <35.00%> (-11.61%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pitop/robotics/drive_controller_4wd.py 26.15% <26.15%> (ø)
pitop/robotics/drive_controller.py 86.25% <71.42%> (+1.17%) :arrow_up:
pitop/__init__.py 100.00% <100.00%> (ø)
pitop/robotics/pan_tilt_controller.py 27.17% <0.00%> (-32.09%) :arrow_down:
pitop/pma/potentiometer.py 50.00% <0.00%> (-10.00%) :arrow_down:
pitop/pma/servo_motor.py 34.93% <0.00%> (-8.82%) :arrow_down:
pitop/pma/light_sensor.py 50.00% <0.00%> (-8.34%) :arrow_down:
pitop/pma/sound_sensor.py 50.00% <0.00%> (-8.34%) :arrow_down:
pitop/core/mixins/supports_miniscreen.py 46.66% <0.00%> (-6.28%) :arrow_down:
pitop/core/mixins/recreatable.py 40.00% <0.00%> (-5.46%) :arrow_down:
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5df5d1...98887a6. Read the comment docs.

codecov[bot] avatar Aug 10 '21 11:08 codecov[bot]

This pull request introduces 1 alert when merging 98887a6b011e5b3b834f5a0753a0a931718cfd70 into c5df5d11db1ce564712cbf1410e9402647296c96 - view on LGTM.com

new alerts:

  • 1 for First parameter of a method is not named 'self'

lgtm-com[bot] avatar Aug 10 '21 11:08 lgtm-com[bot]