pi-top-Python-SDK icon indicating copy to clipboard operation
pi-top-Python-SDK copied to clipboard

[WIP] Improve auto-wrapping text

Open m-roberts opened this issue 4 years ago • 3 comments

Closes #253

This is a draft PR, and is not final. Still needs a clear strategy for how to find the maximum font size so that the whole text fits into the box, considering height and width (w/word wrapping) Note: should have a minimum font size

TODOs: https://github.com/pi-top/pi-top-Python-SDK/pull/254/files#diff-8ff4c1bbe8c2ef3c263d407574ea58158611e8d954011854873177db4d3346e4R20

https://github.com/pi-top/pi-top-Python-SDK/pull/254/files#diff-8ff4c1bbe8c2ef3c263d407574ea58158611e8d954011854873177db4d3346e4R62

m-roberts avatar Feb 25 '21 19:02 m-roberts

Codecov Report

Merging #254 (d74b0db) into master (deb159f) will increase coverage by 0.03%. The diff coverage is 19.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   45.69%   45.73%   +0.03%     
==========================================
  Files          50       50              
  Lines        1998     2005       +7     
==========================================
+ Hits          913      917       +4     
- Misses       1085     1088       +3     
Flag Coverage Δ
unittests 45.73% <19.48%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pitop/core/functions.py 18.03% <18.03%> (ø)
pitop/miniscreen/oled/oled.py 30.88% <25.00%> (+2.88%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update deb159f...d74b0db. Read the comment docs.

codecov[bot] avatar Mar 29 '21 14:03 codecov[bot]

This pull request introduces 1 alert when merging d74b0db0b1d24273825be35369a813b4bfdacb65 into deb159f7d51b3aca97a3c5e1f670cf920f339e19 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

lgtm-com[bot] avatar Apr 12 '21 15:04 lgtm-com[bot]

This PR is quite old now. It's probably best used as guidance for how to write it properly rather than as the basis for an actual code submission

m-roberts avatar Aug 10 '21 10:08 m-roberts