opensheetmusicdisplay icon indicating copy to clipboard operation
opensheetmusicdisplay copied to clipboard

Published 20 hours ago • verified publisher icon opensheetmusicdisplay

Missing ledger line on rest

Open infojunkie opened this issue 3 years ago • 1 comments

I am filing a few bugs referencing this sheet.

This is bug 2 on the OSMD screenshot. OSMD screenshot

The leger line is missing on the rest. Take_These_Broken_Wings-1-MuseScore

infojunkie avatar Feb 12 '22 22:02 infojunkie

Relevant passage from Gould - Behind Bars (p. 37 - Rest symbols): image

sschmidTU avatar Feb 24 '22 14:02 sschmidTU

Fixed in #1463. After: image

Before: image

before the commit below we had the positioning of whole and half rest ledger line mixed up: image

test_ledger_line_rest.musicxml

After: image

Before: image

Take_These_Broken_Wings.musicxml

The approach is very close to https://github.com/0xfe/vexflow/pull/1418, adding a new glyph for whole and half notes with ledger lines.

I initially went for a more complex approach drawing ledger lines using vexflow's standard ledger line system, but first off, it was more complex (only drawing the last ledger line for rests), and secondly the rest positioning in Vexflow/OSMD is quite fickle under certain circumstances, making it difficult to make sure that the note is always under/above the ledger line etc. You can find that apprach on the branch fix/ledger-lines-rest.

The current approach is on fix/ledger-lines-rest-glyph-approach / PR #1463.

sschmidTU avatar Oct 04 '23 19:10 sschmidTU