ember-bulma icon indicating copy to clipboard operation
ember-bulma copied to clipboard

"tree shaking" not working?

Open NullVoxPopuli opened this issue 7 years ago • 4 comments

Using https://github.com/stefanpenner/broccoli-concat-analyser I get this: image

but I have this specified in my env:

    'ember-bulma': {
      // exclude everything by default
      except: [
        'bulma-button',
        'bulma-checkbox',
        'bulma-column',
        'bulma-columns',
        'bulma-container',
        'bulma-control',
        'bulma-footer',
        'bulma-header',
        'bulma-header-menu',
        'bulma-hero-content',
        'bulma-hero-footer',
        'bulma-hero-header',
        'bulma-hero',
        'bulma-input',
        'bulma-menu',
        'bulma-menu-list',
        'bulma-message-body',
        'bulma-message-header',
        'bulma-message',
        'bulma-modal-background',
        'bulma-modal-close',
        'bulma-modal',
        'bulma-nav-center',
        'bulma-nav',
        'bulma-nav-left',
        'bulma-nav-right',
        'bulma-nav-toggle',
        'bulma-notification',
        'bulma-panel-block',
        'bulma-panel',
        'bulma-panel-tabs',
        'bulma-progress',
        'bulma-radio',
        'bulma-section',
        'bulma-select',
        'bulma-table',
        'bulma-tabs',
        'bulma-tag',
        'bulma-textarea',
      ],
    },

just as the docs say to do here: http://open-tux.github.io/ember-bulma/

NullVoxPopuli avatar Jun 21 '18 10:06 NullVoxPopuli

@NullVoxPopuli The tree-shaking implementation was done way back at the beginning of the project. My best guess is that some of the assumptions made then no longer apply. Any chance you'd want to take a shot at debugging? We're a bit light on maintainers these days.

crodriguez1a avatar Jun 21 '18 16:06 crodriguez1a

I tried copying the config into ember-cli-build.js (seems like a common place to put build-related config), and the same issue is still present, all the js still is bundled.

since I don't need any of the js, I just did this:

//ember-cli-build.js
  app.import('node_modules/bulma/bulma.sass');
// app.scss
@import 'node_modules/bulma/bulma';

NullVoxPopuli avatar Jun 26 '18 13:06 NullVoxPopuli

@NullVoxPopuli sounds like you don’t need components? Maybe it makes it sense for you to uninstall ember-bulma and use bulma directly?

crodriguez1a avatar Jun 26 '18 14:06 crodriguez1a

Yeah, I think so.

On Tue, Jun 26, 2018, 10:07 AM Carlos Rodriguez [email protected] wrote:

@NullVoxPopuli https://github.com/NullVoxPopuli sounds like you don’t need components? Maybe it makes it sense for you to uninstall ember-bulma and use bulma directly?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/open-tux/ember-bulma/issues/87#issuecomment-400321845, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMJalHoscyzeBC_4pIJ3w6_e_sW6kBbks5uAkAUgaJpZM4Uxyky .

NullVoxPopuli avatar Jun 26 '18 18:06 NullVoxPopuli