backprop icon indicating copy to clipboard operation
backprop copied to clipboard

Published 20 hours ago • verified publisher icon mstksg

Do not use Data.Semigroup.Option type on base >=4.16.0.0 (i.e. GHC >=9.2.1)

Open msakai opened this issue 3 years ago • 1 comments

As @Mikolaj reported on https://github.com/mstksg/backprop/pull/19#issuecomment-1010063543 , the current master branch fails to compile on GHC 9.2 not only due to the simplified subsumption (#19) but also due to the removal of Data.Semigroup.Option on base >=4.16.0.0.

See also:

  • https://hackage.haskell.org/package/base-4.15.0.0/docs/Data-Semigroup.html#t:Option

    Deprecated: will be removed in GHC 9.2; use Maybe instead.

  • https://hackage.haskell.org/package/base-4.16.0.0/docs/Data-Semigroup.html

This PR fixes the latter problem.

I confirmed that GHC 9.2 can compile this PR + #19 with Vinyl 322476778d11223ac40f1e1c3faddc007eaef72a (I did not use the master branch of Vinyl because of https://github.com/VinylRecords/Vinyl/issues/157) + https://github.com/VinylRecords/Vinyl/issues/156 fix.

msakai avatar Jan 15 '22 08:01 msakai

Vinyl presumably has this [edit: compatibility with GHC 9.2.1] fixed in the just released version.

Mikolaj avatar Feb 17 '22 14:02 Mikolaj

@mstksg any chance to merge this please? (As a Hackage trustee I revised existing releases with base < 4.16 to prohibit unbuildable configurations)

Bodigrim avatar Mar 14 '23 00:03 Bodigrim

thanks! :) apologies for the delay!

mstksg avatar Jul 23 '23 21:07 mstksg