shiro icon indicating copy to clipboard operation
shiro copied to clipboard

Edge case: Daylight savings time

Open mellowagain opened this issue 6 years ago • 1 comments

Today the clocks have been shifted at 2am directly 3am because of Daylight savings time. Shiro however did not update the presence for the user and thus didn't shift the timezone by one. The in-game osu! time was thus outdated.

An already existing dependency of Shiro, Hinnat Date, has the ability to handle daylight savings time using it's Timezone feature. Implementing this should thus be trivial.

mellowagain avatar Mar 31 '19 14:03 mellowagain

I believe it's a bug with osu! client - the time offset is sent to the server on the first request, it already accounts for that, but while the client is connected it can't send the updated time zone, thus the time is off.

48cf avatar Feb 25 '20 04:02 48cf