angular-google-gapi icon indicating copy to clipboard operation
angular-google-gapi copied to clipboard

Published 20 hours ago • verified publisher icon maximepvrt

Autentication should implement new API gapi.auth2

Open fernando-lopez opened this issue 10 years ago • 6 comments

Google has recently updated the API Sign-in Libraries. It should be replaced by the currently used in the project

More details here https://developers.google.com/identity/sign-in/web/reference

fernando-lopez avatar Sep 04 '15 11:09 fernando-lopez

I look that soon. If you you want, you can add this with a pull request

maximepvrt avatar Feb 29 '16 21:02 maximepvrt

@maximepvrt do you have in mind update the library to oauth 2.0?

The library auth is already deprecated https://developers.google.com/api-client-library/javascript/reference/referencedocs#gapiauthauthorizeparams--------callback

There is a risk to impact the apps using this project in case Google disable the library.

fernando-lopez avatar Oct 21 '16 15:10 fernando-lopez

Something to be aware of: The new gapi.auth2 API does not work when the "third party cookies" checkbox in Chrome is ticked, nor in Safari or Chrome's Private Browsing mode, or any other system where third party use of sessionStorage is limited. They have no plans to fix this. So if you upgrade it could actually cause more problems.

google/google-api-javascript-client#246

EugeneZ avatar Nov 28 '16 19:11 EugeneZ

@EugeneZ Thanks for the info. This seems crazy. Disabling third party cookies is a recommended privacy practice.

lukewlms avatar Nov 01 '17 17:11 lukewlms

@lukecwilliams It looks like they might be fixing it, maybe. In the meantime, I have replaced all use of GAPI's javascript client with regular OAuth and REST libraries.

EugeneZ avatar Nov 01 '17 18:11 EugeneZ

@EugeneZ Thanks for the response. We are rolling back the effort to use pop-up authentication, and implementing only the Authentication URL version.

lukewlms avatar Nov 02 '17 13:11 lukewlms