plf_colony
plf_colony copied to clipboard
mattreecebentley
PLF_CPP20_SUPPORT shouldn't be defined on Android NDK r24
As best I can tell, this detection is broken for the Android NDK, which ships with a copy of libc++ that does not implement the concepts header. Maybe it would be appropriate to use _LIBCPP_VERSION? There doesn't appear to be a way for users to override this behavior without patching.
For what it's worth, the relevant NDK issue is android/ndk#1530. They are shipping a libc++ that's something like 2 years out of date compared to the version of clang they're shipping.
Hey Zachary, thanks for getting back to me on this, I'm currently busy on the hive (C++ standards version of colony) implementation, but once done there (probably a month to go) will do this. Cheers! Matt
On 21/05/2022 6:00 am, Zachary Michaels wrote:
For what it's worth, the relevant NDK issue is android/ndk#1530 https://github.com/android/ndk/issues/1530. They are shipping a libc++ that's something like 2 years out of date compared to the version of clang they're shipping.
— Reply to this email directly, view it on GitHub https://github.com/mattreecebentley/plf_colony/issues/46#issuecomment-1133173610, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABE4FIVBAIKIWGGCS7PC54LVK7HMXANCNFSM5UXIN6IA. You are receiving this because you are subscribed to this thread.Message ID: @.***>
