node-feature-discovery icon indicating copy to clipboard operation
node-feature-discovery copied to clipboard

Update CPU flags for ARM, POWER, and Z

Open yselkowitz opened this issue 3 years ago • 12 comments

These updates are based on kernel 5.19.4 and glibc 2.36.

  • cpu: update ARM CPU flags
  • cpu: update POWER CPU flags
  • cpu: update S390 CPU flags

Related: #914 Closes: #913

yselkowitz avatar Oct 13 '22 18:10 yselkowitz

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit cba7ad65525a81532efa74a835f6b5e328b77c8f
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6349a54cd151b20008b65b1d
Deploy Preview https://deploy-preview-919--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 13 '22 18:10 netlify[bot]

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 13 '22 18:10 k8s-ci-robot

/cc @marquiz @mkumatag

yselkowitz avatar Oct 13 '22 18:10 yselkowitz

Thanks @yselkowitz for the update! Looks good to me but I'd like to get thumbs-up from some non-x86 specialist (@mkumatag?) 😊 /ok-to-test

marquiz avatar Oct 14 '22 07:10 marquiz

s390x: lgtm

Thank you @yselkowitz

jschintag avatar Oct 14 '22 09:10 jschintag

ping @pmundt arm

marquiz avatar Oct 14 '22 12:10 marquiz

ping @lubinszARM

marquiz avatar Oct 14 '22 12:10 marquiz

Not to pollute the code base.... however. would a comment pointing back to the source be helpful in future maintenance ?

@yselkowitz this would make sense to me. WDYT

marquiz avatar Oct 14 '22 17:10 marquiz

Rebased and added comments with links to the kernel/glibc sources.

yselkowitz avatar Oct 14 '22 18:10 yselkowitz

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, prb112, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 14 '22 18:10 k8s-ci-robot

/assign @mkumatag

yselkowitz avatar Oct 14 '22 18:10 yselkowitz

arm: lgtm

Good job. @yselkowitz

lubinszARM avatar Oct 17 '22 10:10 lubinszARM

Thanks for all the reviews /lgtm

marquiz avatar Oct 17 '22 13:10 marquiz