node-feature-discovery icon indicating copy to clipboard operation
node-feature-discovery copied to clipboard

apis/nfd: migrate pkg/api/feature

Open marquiz opened this issue 3 years ago • 3 comments

Move the previously-protobuf-only internal "feature api" over to the public "nfd api" package. This is in preparation for introducing a new CRD API for communicating features.

This patch carries no functional changes. Just moving code around.

Split out from #903

marquiz avatar Oct 12 '22 11:10 marquiz

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 12 '22 11:10 k8s-ci-robot

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit c3caf687c828f646fa26b753ac0f2a703569cc52
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/634a3a429fe34f000960148a
Deploy Preview https://deploy-preview-912--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 12 '22 11:10 netlify[bot]

Rebased

marquiz avatar Oct 14 '22 13:10 marquiz