node-feature-discovery

node-feature-discovery copied to clipboard

This PR fixes #863, it's still WIP, but is ready for review.

Design:

• NFR now has two more properties: annotations and annotationsTemplate, which allow setting Node Features as annotations
• Default NS for such annotations is same as labels – feature.node.kubernetes.io, and more can be allowed with extra-annotation-ns
• Unlike labels, profile.node.kubernetes.io is not allowed by default
• Unlike labels, there's a "restricted" ns – feature annotations can't be in nfd.node.kubernetes.io, to avoid conflicts with nfd's internal annotations
• These annotations are tracked in new annotation - feature-annotations, just like feature-labels or extended-resources
• Unlike labels, Annotations can only be set with NodeFeatureRule, and aren't supported on worker side

Docs are yet to be updated, and e2e tests don't cover this new feature at all – partially because there are no e2e tests with NodeFeatureRules in them

It's also written on top of #865, to avoid having to fix conflicts later on, since I'm assuming #865 would be merged before this PR.

Hi @stek29. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stek29 Once this PR has been reviewed and has the lgtm label, please assign marquiz for approval by writing /assign @marquiz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

@stek29: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ping @stek29 are you still planning to work on this?

@marquiz I expected it to be reviewed to know if I should continue working on it.

Realistically -- I don't think I'll work on it in close future.

I expected it to be reviewed to know if I should continue working on it.

Realistically -- I don't think I'll work on it in close future.

K, thanks for the update. Apologies for the unresponsiveness on this, but it was in draft state so mentally in the "I'll look at it the day after" pile...

I think this is a "nice-to-have" feature in the next release so maybe we (e.g. @fmuyassarov or me) could pick up this if we have time? E.g. take part of your work as a base and finalize it with a co-authored-by stamp, wdyt?

I think this is a "nice-to-have" feature in the next release so maybe we (e.g. @fmuyassarov or me) could pick up this if we have time? E.g. take part of your work as a base and finalize it with a co-authored-by stamp, wdyt?

Happy to help on this.

@marquiz @fmuyassarov sure, feel free to use it, it's signed off anyways and is under Apache-2.0 :)

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale