node-feature-discovery
node-feature-discovery copied to clipboard
kubernetes-sigs
test/e2e: add tests for NodeFeatureRules
Add tests covering the basic functionality of NodeFeatureRule objects, covering different feature types ("flag features", "attribute features" and "instance features") as well as backreferencing (using the output of previously run rules) and templating. The test relies on the "fake" feature source and its default configuration.
Fixes: #722
Depends on #845
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: marquiz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [marquiz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
ping @ArangoGutierrez @zvonkok
I think we should do smth about this 😉 Especially with #540 and #863 in the works we'd need to have e2e tests to cover them. At least some baseline on top of which to implement new tests
Deploy Preview for kubernetes-sigs-nfd ready!
| Name | Link |
|---|---|
| Latest commit | 6ef6112d58519d2d4ed663c1b4a4de3353acf5d6 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63457c8f6a789d0009d5cf46 |
| Deploy Preview | https://deploy-preview-848--kubernetes-sigs-nfd.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@zvonkok: Why do fish live in salt water? Because pepper makes them sneeze!
In response to this:
/joke
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.