node-feature-discovery

node-feature-discovery copied to clipboard

Set cpu.tdx-enable to true when TDX is avialable and has been enabled.

/sys/module/kvm_intel/parameters/tdx presence and content is used to detect whether a CPU is Intel TDX capable.

Signed-off-by: Fabiano Fidêncio [email protected]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: fidencio / name: Fabiano Fidêncio (ac9f6dea1738596347c7f38e594634637f15db5a)

Welcome @fidencio!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

Hi @fidencio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/assign

LGTM @marquiz PTAL /cc @mythi

/lgtm

/lgtm

Thanks @fidencio for the PR and sorry for the silence 😇 I think this PR basically looks good when looking at it in isolation. However, in broader perspective I'm growing nervous about the organization of all the somewhat cluttered features regarding security/trusted-execution. No need to solve it as part of this PR, though 😊

I created #832 to track the "re-organization issue". I'd really want to get that resolved before the next release. In terms of code it's not a huge deal (if we decide to do that) but I'd definitely like to hear your opinion on that.

What it comes to this PR (#830), I'd prolly keep it open for now, just to incentivize us to get #832 resolved (sorry about that 🙄)

@marquiz Agree, see my comment on https://github.com/kubernetes-sigs/node-feature-discovery/pull/790#issuecomment-1076183387 enabling PEF for Power. We need to come up with more structure, especially when starting to add ARM CCA and AMD SNP support :) Especially SNP has some sub-features that will extend the list of labels quite a lot.

@fidencio now that #833 is merged you whould rebase this one and I think it could be merged (after review 😊)

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, fidencio, marquiz, mythi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [marquiz]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/retest

/retest